Skip to content

Expected Funds: Add "Created by" filter#11766

Merged
gustavlrsn merged 5 commits intomainfrom
feat/orders-created-by-argument
Jan 12, 2026
Merged

Expected Funds: Add "Created by" filter#11766
gustavlrsn merged 5 commits intomainfrom
feat/orders-created-by-argument

Conversation

@gustavlrsn
Copy link
Member

@gustavlrsn gustavlrsn commented Dec 30, 2025

Resolve opencollective/opencollective#8449
Require opencollective/opencollective-api#11287

Description

  • Adds a "Created by" filter to the Expected Funds tool to filter on who created the expected fund order.
  • Adds a values prop to the filter components that consist of all filter values, so that they can be used when querying for data inside a specific filter (in this case using hostContext, status, and expectedFundsFilter to get the created by options)
  • Unrelated drive-by (but also solved an e2e test that broke): Update the filter bar to not show the last remaining filter right away, this feels unexpected to see the "Add filter" button change to the last remaining filter.

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
opencollective-frontend Ready Ready Preview, Comment Jan 12, 2026 0:46am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
opencollective-styleguide Ignored Ignored Jan 12, 2026 0:46am

@gustavlrsn gustavlrsn requested a review from Betree December 30, 2025 14:40
Comment on lines 30 to 62
@@ -61,7 +59,7 @@ export const AccountRenderer = ({
return (
<AccountHoverCard
account={data.account}
{...(inOptionsList && { hoverCardContentProps: { side: 'right', sideOffset: 24 } })}
{...(props.inOptionsList && { hoverCardContentProps: { side: 'right', sideOffset: 24 } })}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes an issue where only the slug and not the full data (name + avatar) was used to display the current filter value

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gustavlrsn gustavlrsn merged commit 2a89846 into main Jan 12, 2026
19 checks passed
@gustavlrsn gustavlrsn deleted the feat/orders-created-by-argument branch January 12, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected funds: Add filter for “Created by”

2 participants